From: Wincent Colaiuta <win@wincent.com>
Date: Sun, 25 Nov 2007 19:02:33 GMT
Subject: Re: [PATCH] builtin-add: fix command line building to call interactive
Message-ID: <22CBC161-57C2-4A7E-9415-CE8117758A44@wincent.com>
In-Reply-To: <7vlk8mmatu.fsf@gitster.siamese.dyndns.org>

El 25/11/2007, a las 19:36, Junio C Hamano escribió:

> I _think_ the only remaining thing is --patch, and none of the  
> pathspec
> thing is needed.

You're probably right; the pathspec validation is probably not  
necessary (and you may recall that my original patch didn't include  
it; I only tried adding after you said it might be appropriate to have  
the "--error-unmatch" behaviour). This is probably more convenient for  
the user, as it allows them to pass "sloppy" parameters like the  
following:

	git-add -i *.h

(Note that's "*.h" and not "\*.h"). In the Git repository, without  
validation, this just works. With strict validation, it would complain:

	error: pathspec 'common-cmds.h' did not match any file(s) known to git.

So just forgetting about the validation is probably the right thing to  
do.

As for adding the --patch option, I'll stand back and see if someone  
more skilled than I wants to do it; should only be a few lines and  
will save traffic to the list because they'll probably get it right  
first time.

Cheers,
Wincent