From: René Scharfe Date: Sun, 01 Oct 2017 14:54:14 GMT Subject: [PATCH 2/2] commit: use strbuf_add() to add a buffer to a strbuf Message-ID: <223ef0c8-dac2-747b-41c8-3bad62f4c274@web.de> In-Reply-To: <85605bc6-2e91-7132-ce63-f6e08a08a768@web.de> This is shorter, easier and makes the intent clearer. Patch generated with Coccinelle and contrib/coccinelle/strbuf.cocci. Signed-off-by: Rene Scharfe --- builtin/commit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/commit.c b/builtin/commit.c index 0f8ddb6866..d186736617 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -542,7 +542,7 @@ static void export_one(const char *var, const char *s, const char *e, int hack) struct strbuf buf = STRBUF_INIT; if (hack) strbuf_addch(&buf, hack); - strbuf_addf(&buf, "%.*s", (int)(e - s), s); + strbuf_add(&buf, s, e - s); setenv(var, buf.buf, 1); strbuf_release(&buf); } -- 2.14.2