From: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Date: Mon, 30 Jul 2012 20:15:26 GMT
Subject: Re: [RFC v2 11/16] Add explanatory comment for transport-helpers refs mapping.
Message-ID: <2235865.Y0jAeP1uog@flomedio>
In-Reply-To: <20120730191553.GC9564@burratino>

On Monday 30 July 2012 14:15:53 Jonathan Nieder wrote:
> Junio C Hamano wrote:
> > Jonathan Nieder <jrnieder@gmail.com> writes:
> >>> +	/*
> >>> +	 * If the remote helper advertised the "refspec" capability,
> >>> +	 * it will have the written result of the import to the refs
> > 
> > perhaps s/will have the written result of/would have written result of/?
> 
> That would sound like 'If the remote helper advertised the "refspec"
> capability, it would have written the result of the import to the
> refs, but it didn't, so...', so I think "will" is the right tense.
> But 'will have the written' is awkward.  How about:

Yes, thats clearly a typing error of mine, 'the' is to be deleted.

> 
> 	 * The fast-import stream of a remote helper advertising the
> 	 * "refspec" capability writes to the refs named after the right
> 	 * hand side of the first refspec matching each ref we were
> 	 * fetching.
> 	 *
> 	 * (If no "refspec" capability is specified, for historical
> 	 * reasons the default is *:*.)
> 	 *
> 	 * Store the result in to_fetch[i].old_sha1. [...]