From: Ævar Arnfjörð Bjarmason Date: Mon, 07 Nov 2022 14:33:40 GMT Subject: ab/make-bin-wrappers (was: What's cooking in git.git (Nov 2022, #01; Thu, 3)) Message-ID: <221107.86h6zax26k.gmgdl@evledraar.gmail.com> In-Reply-To: On Thu, Nov 03 2022, Taylor Blau wrote: > * ab/make-bin-wrappers (2022-10-31) 4 commits > - Makefile: simplify $(test_bindir_programs) rule by splitting it up > - Makefile: rename "test_bindir_programs" variable, pre-declare > - Makefile: define "TEST_{PROGRAM,OBJS}" variables earlier > - Makefile: factor sed-powered '#!/bin/sh' munging into a variable > > Resolve issues with the bin-wrappers/% rules where "make > bin-wrappers/git" would generate the script but not "git" itself. > > Waiting for review. > source: On my end I'm waiting to see what you and/or Jeff think about: https://lore.kernel.org/git/221101.86edun5tgn.gmgdl@evledraar.gmail.com/ I.e. i can certainly re-roll with a one-line fix, but don't see how it's useful to have a "make" target produce a wrapper that doesn't work.