From: Ævar Arnfjörð Bjarmason Date: Tue, 18 Oct 2022 11:59:39 GMT Subject: Re: [PATCH v2 09/12] fsmonitor: implement filesystem change listener for Linux Message-ID: <221018.86zgdtibif.gmgdl@evledraar.gmail.com> In-Reply-To: <4f9c5358475867af75acd865505884f99801ca17.1665783945.git.gitgitgadget@gmail.com> On Fri, Oct 14 2022, Eric DeCosta via GitGitGadget wrote: > From: Eric DeCosta > [...] > + strbuf_add(&path, w->dir, strlen(w->dir)); > + strbuf_addch(&path, '/'); > + strbuf_add(&path, event->name, strlen(event->name)); Don't do strbuf_add(&buf, x, strlen(x), just use strbuf_addstr(&buf, x) instead. The same goes for a couple of existing occurances that hit "master" already in the just-merged fsmonitor topic, but in this case we can change it in-flight still. Thanks!