From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Tue, 11 Oct 2022 11:07:37 GMT
Subject: Re: [PATCH 5/7] shortlog: implement `--group=author` in terms of `--group=<format>`
Message-ID: <221011.86y1tmobxn.gmgdl@evledraar.gmail.com>
In-Reply-To: <221011.8635bupqx1.gmgdl@evledraar.gmail.com>


On Tue, Oct 11 2022, Ævar Arnfjörð Bjarmason wrote:

> On Mon, Oct 10 2022, Taylor Blau wrote:

>> +void shortlog_init_group(struct shortlog *log)
>> +{
>> +	if (!log->groups)
>> +		log->groups = SHORTLOG_GROUP_AUTHOR;
>> +
>> +	if (log->groups & SHORTLOG_GROUP_AUTHOR)
>
> Nit (easier reading):
>
> 	if (!x)
> 	...
> 	else if (x & FLAG)
> 	...

Urgh, sorry about the noise. That's an obvious logic error, I don't know
what I was thinking...