From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mon, 29 Aug 2022 10:20:13 GMT
Subject: Re: [PATCH v5 05/16] bisect--helper: make `terms` an explicit singleton
Message-ID: <220829.86o7w32vv2.gmgdl@evledraar.gmail.com>
In-Reply-To: <92b3b116ef8f879192d9deb94d68b73e29d5dcd6.1661604264.git.gitgitgadget@gmail.com>


On Sat, Aug 27 2022, Johannes Schindelin via GitGitGadget wrote:

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
> [...]
> -	free((void *)terms->term_good);
> -	terms->term_good = xstrdup(good);
> -	free((void *)terms->term_bad);
> -	terms->term_bad = xstrdup(bad);
> +	free((void *)terms.term_good);
> +	terms.term_good = xstrdup(good);
> +	free((void *)terms.term_bad);
> +	terms.term_bad = xstrdup(bad);
>  }

This is pre-existing, and dates back to 0f30233a11f (bisect--helper:
`bisect_write` shell function in C, 2019-01-02), but it appears this
cast to a "void *" was never needed. Perhaps some C++-ism that crept in
here?

As we're changing this all around perhaps it's worth droppping the cast,
or it could be left for some other "remove redundant casts" series.