From: Ævar Arnfjörð Bjarmason Date: Thu, 18 Aug 2022 18:43:22 GMT Subject: Re: [PATCH v4 07/11] builtin/diagnose.c: create 'git diagnose' builtin Message-ID: <220818.86edxd8k8q.gmgdl@evledraar.gmail.com> In-Reply-To: On Fri, Aug 12 2022, Victoria Dye via GitGitGadget wrote: > From: Victoria Dye > [...] This is correct: > +'git diagnose' [(-o | --output-directory) ] [(-s | --suffix) ] ... > + N_("git diagnose [-o|--output-directory ] [-s|--suffix ]"), But this is not, it's missing () around the short v.s. long option, and we should have a space surrounding the "|" as well.