From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 04 Aug 2022 06:24:25 GMT
Subject: Re: [PATCH v2 05/10] scalar-diagnose: move functionality to common location
Message-ID: <220804.864jysfrtr.gmgdl@evledraar.gmail.com>
In-Reply-To: <3a0cb33c6583b591b1bbb51a3886f18023813d5b.1659577543.git.gitgitgadget@gmail.com>


On Thu, Aug 04 2022, Victoria Dye via GitGitGadget wrote:

> From: Victoria Dye <vdye@github.com>
> [...]
> diff --git a/diagnose.h b/diagnose.h
> new file mode 100644
> index 00000000000..e86e8a3c962
> --- /dev/null
> +++ b/diagnose.h
> @@ -0,0 +1,9 @@
> +#ifndef DIAGNOSE_H
> +#define DIAGNOSE_H
> +
> +#include "cache.h"

We don't need cache.h here, just ...

> +#include "strbuf.h"

...this, also a matter of preference, but we could also just skip the
includes here and use a forward decl (as is common in other headers):

	struct strbuf;

> +
> +int create_diagnostics_archive(struct strbuf *zip_path);
> +
> +#endif /* DIAGNOSE_H */