From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 28 Jul 2022 20:55:31 GMT
Subject: Re: [PATCH] format-patch: clarify --creation-factor=<factor>
Message-ID: <220728.867d3xj6s0.gmgdl@evledraar.gmail.com>
In-Reply-To: <20220728174953.66964-1-sunshine@sunshineco.com>


On Thu, Jul 28 2022, Eric Sunshine wrote:

> The value is not a percentage that ranges from 0 to 100, so stop
> referring to it as `percent`; instead follow the lead of the `git
> range-diff` documentation and call it `factor`.
>
> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
> ---
>
> This is a sibling to Junio's patch[1].
>
> [1]: https://lore.kernel.org/git/xmqqo7x9ch7n.fsf_-_@gitster.g/
>
>  Documentation/git-format-patch.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt
> index be797d7a28..e06475abcd 100644
> --- a/Documentation/git-format-patch.txt
> +++ b/Documentation/git-format-patch.txt
> @@ -27,7 +27,7 @@ SYNOPSIS
>  		   [--[no-]encode-email-headers]
>  		   [--no-notes | --notes[=<ref>]]
>  		   [--interdiff=<previous>]
> -		   [--range-diff=<previous> [--creation-factor=<percent>]]
> +		   [--range-diff=<previous> [--creation-factor=<factor>]]
>  		   [--filename-max-length=<n>]
>  		   [--progress]
>  		   [<common diff options>]
> @@ -321,7 +321,7 @@ product of `format-patch` is generated, and they are not passed to
>  the underlying `range-diff` machinery used to generate the cover-letter
>  material (this may change in the future).
>  
> ---creation-factor=<percent>::
> +--creation-factor=<factor>::
>  	Used with `--range-diff`, tweak the heuristic which matches up commits
>  	between the previous and current series of patches by adjusting the
>  	creation/deletion cost fudge factor. See linkgit:git-range-diff[1])

Looks good as far as it goes, looks like both of your patches need to
also tweak this bit though:

	$ git -P grep 'percentage.*creation' -- '*.c'
	builtin/log.c:                      N_("percentage by which creation is weighted")),
	builtin/range-diff.c:                       N_("percentage by which creation is weighted")),

Probably just s/percentage/factor/ in for those -h strings?