From: Ævar Arnfjörð Bjarmason Date: Wed, 13 Jul 2022 01:25:24 GMT Subject: Re: [PATCH v4 1/4] revision: improve commit_rewrite_person() Message-ID: <220713.86mtdd4xdd.gmgdl@evledraar.gmail.com> In-Reply-To: <20220712160634.213956-2-siddharthasthana31@gmail.com> On Tue, Jul 12 2022, Siddharth Asthana wrote: > -static int commit_rewrite_person(struct strbuf *buf, const char *what, struct string_list *mailmap) > +/* > + * Returns the difference between the new and old length of the ident line. > + */ > +static ssize_t rewrite_ident_line(const char* person, struct strbuf *buf, struct string_list *mailmap) All tests pass with this as size_t, instead of size_t. Let's use that here instead?