From: Ævar Arnfjörð Bjarmason Date: Tue, 24 May 2022 07:58:51 GMT Subject: Re: [PATCH 3/4] http.c: avoid danging pointer to local variable `finished` Message-ID: <220524.86fskzxsvq.gmgdl@evledraar.gmail.com> In-Reply-To: <4a4e0aa0a49a54eea88f9c2d8e1db6a697012718.1653351786.git.gitgitgadget@gmail.com> On Tue, May 24 2022, Johannes Schindelin via GitGitGadget wrote: > From: Johannes Schindelin > [...] > Let's drop that local variable and introduce a new flag in the slot that > is used to indicate that even while the slot is no longer in use, it is > still reserved until further notice. It is the responsibility of > `run_active_slot()` to clear that flag once it is done with that slot. > > Initial-patch-by: Junio C Hamano Don't you mean by me? I.e. https://lore.kernel.org/git/patch-1.1-1cec367e805-20220126T212921Z-avarab@gmail.com/ This seems to be derived from that, or perhaps you just came up with something similar independently. Junio then came up with the smaller https://lore.kernel.org/git/xmqq8rv2nggn.fsf@gitster.g/