From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Fri, 20 May 2022 07:30:22 GMT
Subject: Re: [PATCH v4 3/7] scalar: validate the optional enlistment argument
Message-ID: <220520.86fsl43bkf.gmgdl@evledraar.gmail.com>
In-Reply-To: <xmqqbkvuwxps.fsf@gitster.g>


On Wed, May 18 2022, Junio C Hamano wrote:

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>>> +test_expect_success '`scalar [...] <dir>` errors out when dir is missing' '
>>> +	! scalar run config cloned 2>err &&
>>
>> Needs to use test_must_fail, not !
>
> Good eyes and careful reading are very much appreciated, but in this
> case, doesn't such an improvement depend on an update to teach
> test_must_fail_acceptable about scalar being whitelisted?

Yes, I think so (but haven't tested it just now), but it's a relatively
small change to t/test-lib-functions.sh.

I was just noting the potential hidden segfault etc., the issue remains
in v5.