From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 19 May 2022 11:29:26 GMT
Subject: Re: [PATCH v4 12/17] builtin/repack.c: support generating a cruft pack
Message-ID: <220519.86v8u14v52.gmgdl@evledraar.gmail.com>
In-Reply-To: <5992a72cbf9e8d076f1e312a789b40d52656ad3c.1652915424.git.me@ttaylorr.com>


On Wed, May 18 2022, Taylor Blau wrote:

> +		tip="$(git rev-parse cruft)" &&

Here we don't hide the exit status of "git", as it'll be reflected in what's &&-chained.

> +		path="$objdir/$(test_oid_to_path "$(git rev-parse cruft)")" &&

But here we do, as we'll get the exit status of test_oid_to_path. But as
we just rev parsed it shouldn't this be $tip in any case?