From: Ævar Arnfjörð Bjarmason Date: Mon, 21 Mar 2022 09:20:34 GMT Subject: Re: [PATCH v13 16/16] ls-tree: split up "fast path" callbacks Message-ID: <220321.865yo7d5ki.gmgdl@evledraar.gmail.com> In-Reply-To: <010e3c0eceac0a936a447a6df7ba8c9abb7c77b2.1647846935.git.dyroneteng@gmail.com> On Mon, Mar 21 2022, Teng Long wrote: > From: Ævar Arnfjörð Bjarmason > > Make the various if/else in the callbacks for the "fast path" a lot > easier to read by just using common functions for the parts that are > common, and have per-format callbacks for those parts that are > different. FWIW I didn't do any exhaustive benchmarks of this, but I checked a few things against origin/master on linux.git and all the reported "hyperfine" timings were the same/within the +/- interval.