From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Fri, 11 Mar 2022 11:57:35 GMT
Subject: Re: [PATCH v6 01/11] t2501: add various tests for removing the current working directory
Message-ID: <220311.86tuc4hf4p.gmgdl@evledraar.gmail.com>
In-Reply-To: <1fd76d4f8a8c98d3c78c94cc8f3d36c335bd3bfb.1639026515.git.gitgitgadget@gmail.com>


On Thu, Dec 09 2021, Elijah Newren via GitGitGadget wrote:

> From: Elijah Newren <newren@gmail.com>
> [...]
> +test_expect_success 'git version continues working from a deleted dir' '
> +	mkdir tmp &&
> +	(
> +		cd tmp &&
> +		rm -rf ../tmp &&
> +		git version
> +	)
> +'

There's a (minor) regression here in v2.35.0 on AIX (as of 8a0d52dfd87
(t2501: add various tests for removing the current working directory,
2021-12-09)). The tooling on that OS will also refuse to remove the cwd:
    
    + mkdir tmp
    + cd tmp
    + rm -rf ../tmp
    rm: Cannot remove the current directory ../tmp.
    error: last command exited with $?=2
    not ok 21 - git version continues working from a deleted dir
    #

Just splitting that into a prereq that checks if the first two lines of
the sub-shell works should be a solution in this case, but I only had
time for this quick bug report :)