From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Fri, 11 Mar 2022 13:44:36 GMT
Subject: Re: [PATCH 10/25] bundle: add --filter option to 'fetch'
Message-ID: <220311.86h784habh.gmgdl@evledraar.gmail.com>
In-Reply-To: <fa0e83b39dd3c3bb16e932c39aff080a1fdf8fe4.1645641063.git.gitgitgadget@gmail.com>


On Wed, Feb 23 2022, Derrick Stolee via GitGitGadget wrote:

> From: Derrick Stolee <derrickstolee@github.com>
> [...]
> +			/* Skip if filter does not match. */
> +			if (!filter && info->filter_str)
> +				continue;
> +			if (filter &&
> +			    (!info->filter_str || strcasecmp(filter, info->filter_str)))
> +				continue;

General API comment: Do we have a need for strcasecmp() now anywhere
when dealing with filters?

    $ git clone --no-checkout --filter=BlOb:nOnE https://github.com/git/git
    fatal: invalid filter-spec 'BlOb:nOnE'