From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 10 Mar 2022 15:10:36 GMT
Subject: Re: [PATCH 17/24] revisions API: have release_revisions() release "cmdline"
Message-ID: <220310.86sfrpj0t0.gmgdl@evledraar.gmail.com>
In-Reply-To: <4e564691-0ef6-a867-647e-c26064b0bb36@github.com>


On Wed, Mar 09 2022, Derrick Stolee wrote:

> On 3/9/2022 8:16 AM, Ævar Arnfjörð Bjarmason wrote:
>> Extend the the release_revisions() function so that it frees the
>> "cmdline" in the "struct ref_info". This in combination with a
>> preceding change to free "commits" and "mailmap" means that we can
>> whitelist another test under "TEST_PASSES_SANITIZE_LEAK=true".
>
> Could you consider changing your vocabulary to use "allowlist"
> (with the opposite term being "denylist")?

I looked at some of the wording with past changes like that, which in
some cases was entirely different. See some of:

    git log --grep=SANITIZE

But I figred for the nascent v2 re-roll that avoiding the churn was
better, particularly since there's various similar phrasing on "master"
already.