From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mon, 07 Mar 2022 15:44:29 GMT
Subject: Re: [PATCH 10/11] bundle: create filtered bundles
Message-ID: <220307.867d95zryi.gmgdl@evledraar.gmail.com>
In-Reply-To: <5393e74708dfd38e5596d9e877a491e6ed8dda24.1645638911.git.gitgitgadget@gmail.com>


On Wed, Feb 23 2022, Derrick Stolee via GitGitGadget wrote:

> From: Derrick Stolee <derrickstolee@github.com>

Just something missed by Junio....

> +for filter in "blob:none" "tree:0" "tree:1" "blob:limit=100"
> +do
> +	test_expect_success 'filtered bundle: $filter' '

I think you'll need "" here, the description part of test_expect_success
isn't eval'd.

> +		test_when_finished rm -rf .git/objects/pack &&
> +		git bundle create partial.bdl \
> +			--all \
> +			--filter=$filter &&
> +
> +		git bundle verify partial.bdl >unfiltered &&
> +		make_user_friendly_and_stable_output <unfiltered >actual &&
> +
> +		cat >expect <<-EOF &&
> +		The bundle contains these 10 refs:
> +		<COMMIT-P> refs/heads/main
> +		<COMMIT-N> refs/heads/release
> +		<COMMIT-D> refs/heads/topic/1
> +		<COMMIT-H> refs/heads/topic/2
> +		<COMMIT-D> refs/pull/1/head
> +		<COMMIT-G> refs/pull/2/head
> +		<TAG-1> refs/tags/v1
> +		<TAG-2> refs/tags/v2
> +		<TAG-3> refs/tags/v3
> +		<COMMIT-P> HEAD
> +		The bundle uses this filter: $filter
> +		The bundle records a complete history.
> +		EOF
> +		test_cmp expect actual
> +	'
> +done
> +
>  test_done

I think this needs a corresponding documentation update, now "verify"
just talks about output related to whether the history is complete or
not.