From: Ævar Arnfjörð Bjarmason Date: Fri, 04 Mar 2022 18:33:05 GMT Subject: Re: ab/plug-random-leaks (was Re: What's cooking in git.git (Mar 2022, #01; Thu, 3)) Message-ID: <220304.861qzhftzc.gmgdl@evledraar.gmail.com> In-Reply-To: <5f8740bd-c0b7-a8e1-4d73-b79b40cc02e9@github.com> On Fri, Mar 04 2022, Derrick Stolee wrote: > On 3/3/2022 11:31 PM, Junio C Hamano wrote: > >> * ab/plug-random-leaks (2022-03-02) 14 commits >> - repository.c: free the "path cache" in repo_clear() >> - range-diff: plug memory leak in read_patches() >> - range-diff: plug memory leak in common invocation >> - lockfile API users: simplify and don't leak "path" >> - commit-graph: stop fill_oids_from_packs() progress on error and free() >> - commit-graph: fix memory leak in misused string_list API >> - submodule--helper: fix trivial leak in module_add() >> - transport: stop needlessly copying bundle header references >> - bundle: call strvec_clear() on allocated strvec >> - remote-curl.c: free memory in cmd_main() >> - urlmatch.c: add and use a *_release() function >> - diff.c: free "buf" in diff_words_flush() >> - merge-base: free() allocated "struct commit **" list >> - index-pack: fix memory leaks >> >> Plug random memory leaks. >> >> Will merge to 'next'. >> source: > > This series needs a re-roll before it gets merged. There is > a correctness issue in this patch: > >> - transport: stop needlessly copying bundle header references Thanks. I just sent in that re-roll at: https://lore.kernel.org/git/cover-v2-00.14-00000000000-20220304T182902Z-avarab@gmail.com/