From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 03 Mar 2022 15:46:22 GMT
Subject: Re: [PATCH 12/15] gettext tests: don't ignore "test-tool regex" exit code
Message-ID: <220303.86zgm72g3j.gmgdl@evledraar.gmail.com>
In-Reply-To: <xmqq5yowgcvg.fsf@gitster.g>


On Wed, Mar 02 2022, Junio C Hamano wrote:

> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>> -test_have_prereq GETTEXT_LOCALE &&
>> -test-tool regex "HALLÓ" "Halló" ICASE &&
>> -test_set_prereq REGEX_LOCALE
>> +test_expect_success GETTEXT_LOCALE 'setup REGEX_LOCALE prerequisite' '
>> +	if test-tool regex "HALLÓ" "Halló" ICASE
>> +	then
>> +		test_set_prereq REGEX_LOCALE
>
> This looks sensible but
>
>> +	else
>> +		test_must_fail test-tool regex "HALLÓ" "Halló" ICASE
>
> this side looks puzzling.  I think this way to avoid counting abort
> etc as passing "must fail" test would be the least bad that we can
> do.
>
> Nicely done.

Thanks. For the purposes of a re-roll I'll note this as a "nothing to
change", since the commit message explains why we're doing this, unless
you have comments on that explanation (the last paragraph of the commit
message).