From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Tue, 01 Mar 2022 08:07:34 GMT
Subject: Re: [PATCH v2 12/13] submodule update: add tests for --filter
Message-ID: <220301.86bkyq14e9.gmgdl@evledraar.gmail.com>
In-Reply-To: <20220301044132.39474-13-chooglen@google.com>


On Mon, Feb 28 2022, Glen Choo wrote:

> Test the "--filter" option to make sure we don't break anything while
> refactoring "git submodule update".
>
> Signed-off-by: Glen Choo <chooglen@google.com>
> ---
>  t/t7406-submodule-update.sh | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh
> index 7764c1c3cb..6cc60ff5e5 100755
> --- a/t/t7406-submodule-update.sh
> +++ b/t/t7406-submodule-update.sh
> @@ -1071,4 +1071,17 @@ test_expect_success 'submodule update --quiet passes quietness to fetch with a s
>  	)
>  '
>  
> +test_expect_success 'submodule update --filter requires --init' '
> +	test_must_fail git -C super submodule update --filter blob:none 2>err &&

Should be "test_expect_code 129" (presumably, or is it 128). In any case
other similar "usage" test check for that:

> +	grep "usage:" err

We could retain this then, but FWIW if it's 129 other tests consider it
redundant.