From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Tue, 01 Mar 2022 09:37:21 GMT
Subject: Re: [PATCH] userdiff: Add diff driver for Kotlin lang and tests
Message-ID: <220301.867d9e107u.gmgdl@evledraar.gmail.com>
In-Reply-To: <20220301070226.2477769-2-jaydeepjd.8914@gmail.com>


On Tue, Mar 01 2022, Jaydeep P Das wrote:

> The xfuncname pattern finds func/class declarations
> in diffs to display as a hunk header.
>
> This patch adds xfuncname regex and some respective
> tests for Kotlin language.
>
> Also modifies `Documentation./gitattributes.txt` to state
> the same.
>
> Signed-off-by: Jaydeep P Das <jaydeepjd.8914@gmail.com>
> ---
>  Documentation/gitattributes.txt | 2 ++
>  t/t4018/kotlin-class            | 5 +++++
>  t/t4018/kotlin-enum-class       | 5 +++++
>  t/t4018/kotlin-fun              | 5 +++++
>  t/t4018/kotlin-inheritace-class | 5 +++++
>  t/t4018/kotlin-inline-class     | 5 +++++
>  t/t4018/kotlin-interface        | 5 +++++
>  t/t4018/kotlin-nested-fun       | 9 +++++++++
>  t/t4018/kotlin-public-class     | 5 +++++
>  t/t4018/kotlin-sealed-class     | 5 +++++
>  userdiff.c                      | 8 ++++++++

I didn't look at the regexes etc. at a glance, but this is missing the
corresponding tests for the word-diff part of the regexes. It would be
nice to have those tests too.

See the t/t4034/ directory for that (and no, this whole setup isn't very
discoverable, sorry!).