From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 24 Feb 2022 09:08:59 GMT
Subject: ab/commit-plug-leaks + ab/diff-free-more (was: What's cooking in git.git (Feb 2022, #06; Wed, 23))
Message-ID: <220224.86k0dkaaun.gmgdl@evledraar.gmail.com>
In-Reply-To: <xmqq1qztortk.fsf@gitster.g>


On Wed, Feb 23 2022, Junio C Hamano wrote:

> * ab/commit-plug-leaks (2022-02-16) 2 commits
>  - commit: use strbuf_release() instead of UNLEAK()
>  - commit: fix "author_ident" leak
>
>  Leakfixes in the top-level called-once function.
>
>  Expecting a reroll.
>  I think UNLEAK->strbuf_release() is a regression.
>  source: <cover-0.2-00000000000-20220216T081844Z-avarab@gmail.com>

After you noted that in [1] I followed-up in [2] giving reasons for
wanting to keep that UNLEAK->strbuf_release() change. What do you think
about that?

> * ab/diff-free-more (2022-02-16) 2 commits
>   (merged to 'next' on 2022-02-17 at be8ae78a2d)
>  + diff.[ch]: have diff_free() free options->parseopts
>  + diff.[ch]: have diff_free() call clear_pathspec(opts.pathspec)
>
>  Leakfixes.
>
>  Will merge to 'master'.
>  source: <cover-0.2-00000000000-20220216T105250Z-avarab@gmail.com>

Thanks! It will be great to have this merged down!

1. https://lore.kernel.org/git/xmqqwnhs11he.fsf@gitster.g/
2. https://lore.kernel.org/git/220218.86fsoggdou.gmgdl@evledraar.gmail.com