From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Tue, 15 Feb 2022 21:33:07 GMT
Subject: Re: [PATCH v2 5/9] submodule: store new submodule commits oid_array in a struct
Message-ID: <220215.86zgmrx19l.gmgdl@evledraar.gmail.com>
In-Reply-To: <20220215172318.73533-6-chooglen@google.com>


On Wed, Feb 16 2022, Glen Choo wrote:

>  	struct string_list_item *item;
> -	for_each_string_list_item(item, submodules)
> -		oid_array_clear((struct oid_array *) item->util);
> +	for_each_string_list_item(item, submodules) {
> +		changed_submodule_data_clear(item->util);
> +	}

Nit: These {} additions aren't needed here or in the end state of this
series.