From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sat, 12 Feb 2022 14:38:23 GMT
Subject: Re: [PATCH v7 12/20] submodule--helper run-update-procedure: learn --remote
Message-ID: <220212.86pmnsxi6e.gmgdl@evledraar.gmail.com>
In-Reply-To: <20220210092833.55360-13-chooglen@google.com>


On Thu, Feb 10 2022, Glen Choo wrote:

>  #define UPDATE_DATA_INIT { \
>  	.update_strategy = SUBMODULE_UPDATE_STRATEGY_INIT, \
> @@ -2585,6 +2571,8 @@ static int run_update_procedure(int argc, const char **argv, const char *prefix)
>  		OPT_CALLBACK_F(0, "oid", &opt.oid, N_("sha1"),
>  			       N_("SHA1 expected by superproject"), PARSE_OPT_NONEG,
>  			       parse_opt_object_id),
> +		OPT_BOOL(0, "remote", &opt.remote,
> +			 N_("use SHA-1 of submodule's remote tracking branch")),

For some things the references to SHA-1 are faithfully copying existing
test, but for new things let's use "object" instead.