From: Richard Hansen <hansenr@google.com>
Date: Wed, 11 Jan 2017 17:24:57 GMT
Subject: Re: [PATCH 2/2] diff: document the pattern format for diff.orderFile
Message-ID: <21b416ae-8bf6-4f82-25d3-e51a574e7746@google.com>
In-Reply-To: <xmqq60lmpb4j.fsf@gitster.mtv.corp.google.com>

On 2017-01-10 21:46, Junio C Hamano wrote:
> Richard Hansen <hansenr@google.com> writes:
>
>> I was looking at the code to see how the two file formats differed and
>> noticed that match_order() doesn't set the WM_PATHNAME flag when it
>> calls wildmatch().  That's unintentional (a bug), right?
>
> It has been that way from day one IIRC even before we introduced
> wildmatch()---IOW it may be intentional that the current code that
> uses wildmatch() does not use WM_PATHNAME.

You are the original author (af5323e027 2005-05-30).  Do you remember 
what your intention was?

I would like to change it to pass WM_PATHNAME, but I'm not sure if that 
would break anyone.  I'm guessing probably not, because users probably 
expect WM_PATHNAME and would be surprised (like I was) to learn otherwise.

If we want to keep it as-is, I'll have to adjust [PATCH v2 2/2].

-Richard