From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Wed, 11 Aug 2021 06:44:59 GMT
Subject: Re: [GSoC] [PATCH v5 1/9] submodule--helper: add options for compute_submodule_clone_url()
Message-ID: <21917b01-94f7-2698-b904-2d75f37af447@gmail.com>
In-Reply-To: <20210810114641.27188-2-raykar.ath@gmail.com>

On 10/08/21 18.46, Atharva Raykar wrote:
>   	if (git_config_get_string(remotesb.buf, &remoteurl)) {
> -		warning(_("could not look up configuration '%s'. Assuming this repository is its own authoritative upstream."), remotesb.buf);
> +		if (!quiet)
> +			warning(_("could not look up configuration '%s'. "
> +				  "Assuming this repository is its own "
> +				  "authoritative upstream."),
> +				remotesb.buf);
>   		remoteurl = xgetcwd();
>   	}

Why did you split warning message? We could keep that in one line.

-- 
An old man doll... just what I always wanted! - Clara