From: Kristoffer Haugsbakk Date: Sun, 24 Nov 2024 20:01:01 GMT Subject: Re: [PATCH v2 0/3] sequencer: comment out properly in todo list Message-ID: <2160428c-2e33-4c13-9b64-fe6a890ba494@app.fastmail.com> In-Reply-To: On Wed, Nov 13, 2024, at 01:26, Junio C Hamano wrote: > kristofferhaugsbakk@fastmail.com writes: > >> The first version just had patch 1 but this one fixes two other places. >> The two other places where unearthered during the v1 discussion. > > OK. I guess they could be handled in a single patch, but the three > patches address different things to be commented properly, so having > them as three separate patches is good. > >> Rebased on `master` (b31fb630c0 (Merge https://github.com/j6t/git-gui, >> 2024-11-11)). > > Was there any reason, other than "newer must be better" (which is > not always true)? I thought there isn't any in-flight topics that > touched the sequencer machinery. I’m sorry. I worked on the v2 by rebasing on `jc/strbuf-commented-something` which was in `seen` at the time. Then when I had to `rebase --onto` back someplace I picked `master` since I didn’t need the interdiff for the cover letter (two new patches, no changes to the first one).