From: Phillip Wood <phillip.wood123@gmail.com>
Date: Fri, 12 May 2023 14:54:46 GMT
Subject: Re: [PATCH v5 7/7] strbuf: remove global variable
Message-ID: <215b700d-6175-3527-857d-4347bb4efb95@gmail.com>
In-Reply-To: <xmqqr0rmtuid.fsf@gitster.g>

On 11/05/2023 22:42, Junio C Hamano wrote:
> Calvin Wan <calvinwan@google.com> writes:
>
> So this step, while it makes sense in a vacuum, is a cute idea, and
> is nicer in the longer term (because we certainly do not want to
> have to pass an extra parameter to the function), raises the risk of
> semantic mismerge higher for topics in flight that do want to use
> stripspace to remove lines that are commented out.  My quick "git
> log -S" seems to tell me there is no such topic I happened to have
> picked up in 'seen' right now, though, so it may be OK.

I just grepped seen for strbuf_stripspace() and it looks like all the 
callers are converted correctly.

Best Wishes

Phillip