From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sat, 18 Dec 2021 09:58:01 GMT
Subject: Re: [PATCH 1/2] repack: respect kept objects with '--write-midx -b'
Message-ID: <211218.86wnk2w7uq.gmgdl@evledraar.gmail.com>
In-Reply-To: <1ed91f6d255b76bdbdcccea7e1effcebbb263ced.1639758526.git.gitgitgadget@gmail.com>


On Fri, Dec 17 2021, Derrick Stolee via GitGitGadget wrote:

> +test_expect_success '--write-midx -b packs non-kept objects' '
> +	git init midx-kept &&
> +	test_when_finished "rm -fr midx-kept" &&

Nit: Better the other way around, so we'll clean up things if "git init"
dies midway, but unlikely to ever happen here.

> +	(
> +		cd midx-kept &&
> +		test_commit_bulk 100 &&
> +		GIT_TRACE2_EVENT="$(pwd)/trace.txt" \
> +			git repack --write-midx -a -b &&
> +		cat trace.txt | \
> +			grep \"event\":\"start\" | \

The "cat" here should go in favor of "grep <pat> trace.txt", and can't
this all be on one grep line with "." between the relevant parts you're
extracting out?