From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Fri, 03 Dec 2021 13:59:29 GMT
Subject: Re: [PATCH v4 4/5] unpack-objects.c: add dry_run mode for get_data()
Message-ID: <211203.86ee6tss9p.gmgdl@evledraar.gmail.com>
In-Reply-To: <20211203093530.93589-5-chiyutianyi@gmail.com>


On Fri, Dec 03 2021, Han Xin wrote:

> +	unsigned long bufsize = dry_run ? 4096 : size;
> +	void *buf = xmallocz(bufsize);

It's probably nothing, but in your CL you note that you changed another
hardcoding from 4k to 8k, should this one still be 4k?

It's probably fine, just wondering...