From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Wed, 10 Nov 2021 03:57:40 GMT
Subject: Re: [PATCH v5 2/4] receive-pack: Clean dead code from update_worktree()
Message-ID: <211110.86y25wirtj.gmgdl@evledraar.gmail.com>
In-Reply-To: <20211109230941.2518143-2-andersk@mit.edu>


On Tue, Nov 09 2021, Anders Kaseorg wrote:

> +	if (!worktree || !worktree->path)
> +		BUG("worktree->path must be non-NULL");

Perhaps a metter of taste, but I think BUG() should really be used for
things that need a custom message over and beyond what assert() gives
us.

In this case using BUG() gives you a worse message, if you do:

    assert(worktree && worktree->path)

You'll get a sensible message from any modern compiler quotign the
variable etc, all of which says the same thing as that BUG() message,
just with less verbosity.