From: Ævar Arnfjörð Bjarmason Date: Fri, 22 Oct 2021 17:19:26 GMT Subject: Re: [PATCH v2 2/3] config.c: don't leak memory in handle_path_include() Message-ID: <211022.86ilxpj7si.gmgdl@evledraar.gmail.com> In-Reply-To: On Thu, Oct 21 2021, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Fix a memory leak in the error() path in handle_path_include(), this >> allows us to run t1305-config-include.sh under SANITIZE=leak, >> previously 4 tests there would fail. This fixes up a leak in >> 9b25a0b52e0 (config: add include directive, 2012-02-06). >> >> Signed-off-by: Ævar Arnfjörð Bjarmason >> --- >> config.c | 7 +++++-- >> t/t1305-config-include.sh | 1 + >> 2 files changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/config.c b/config.c >> index 2dcbe901b6b..c5873f3a706 100644 >> --- a/config.c >> +++ b/config.c >> @@ -148,8 +148,10 @@ static int handle_path_include(const char *path, struct config_include_data *inc > > Not a problem introduced by this function, but if you look at this > change with "git show -W", we'd notice that the function name on the > hunk header looks strange. I think we should add a blank line > before the beginning of the function. I think this is a bug in -W, after all if without it we we show the function context line, but with it we advance further, then that means that -W didn't find the correct function boundary.