From: Kristoffer Haugsbakk Date: Wed, 10 Sep 2025 20:23:50 GMT Subject: Re: [PATCH v4 1/7] git: add `deprecated` category to --list-cmds Message-ID: <20fd7486-5f65-490c-866e-d07a19d2b75a@app.fastmail.com> In-Reply-To: On Tue, Sep 9, 2025, at 23:44, Junio C Hamano wrote: > kristofferhaugsbakk@fastmail.com writes: > >> Incorporate Patrick’s suggestions about the for-loop refactor and >> formatting the overlong lines. Now drop the function doc since it >> doesn’t apply anymore. > > So, if "include" is specified, a command that does not match any of > criteria given by those flags is not included, and if "exclude" is > specified, a command that matches any of the criteria given is not > included. Which probably makes sense. On second thought I want to add back the “mutually exclusive” check since using both still doesn’t make sense. (Dunno why I thought otherwise. Patrick’s change was strictly a refactoring.) > The only user of "include" uses the DEPRECATED flag bit without any > exclude option, so it is yet to be seen which one between the previous > and the current design gives an easier-to-use behaviour, but I have no > objection to the updated design presented here. I’m happy with it. :) But people can suggest an alternative if they would like only one of the include/exclude. Us Java app. programmers are only permitted to practice bitfields in our spare time. -- Kristoffer