From: Louis-Alexandre Stuber Date: Wed, 10 Jun 2015 09:41:44 GMT Subject: Re: [PATCH 3/4] bisect: simplify the add of new bisect terms Message-ID: <2070840481.381260.1433929304815.JavaMail.zimbra@ensimag.grenoble-inp.fr> In-Reply-To: But ENOENT is not a normal case at all. Should we not treat it the same way as other fopen() errors ? (either going on with default case or returning an error) Would : > if (!fp) { > die("could not read file '%s': %s", > filename, strerror(errno)); > } else { be ok ?