From: Christian Couder Date: Fri, 20 Nov 2026 16:48:21 GMT Subject: [PATCH v2 8/8] doc: gitprotocol-v2: send the promisor-remote reply with fetch Message-ID: <20261120164812.707946-18-christian.couder@gmail.com> In-Reply-To: <20261120164812.707946-10-christian.couder@gmail.com> Until a previous commit, a client sent its `promisor-remote=...` reply only with the `ls-refs` and `bundle-uri` protocol commands. Let's clearly document that the client should send that reply with each `fetch` command request asking for a pack too, as protocol v2 is stateless. The `fetch` requests sent only for negotiation, like with `git fetch --negotiate-only`, don't ask for a pack, so they don't need that reply. Reported-by: Matt Cote Signed-off-by: Christian Couder --- Documentation/gitprotocol-v2.adoc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/gitprotocol-v2.adoc b/Documentation/gitprotocol-v2.adoc index dd52fd8110..d70d7ab19b 100644 --- a/Documentation/gitprotocol-v2.adoc +++ b/Documentation/gitprotocol-v2.adoc @@ -879,6 +879,13 @@ In this case, or if the client doesn't want to use any promisor remote the server advertised, the client shouldn't advertise the "promisor-remote" capability at all in its reply. +As protocol v2 is stateless (see the "Capabilities" section above), +the client should send this reply with each `fetch` command request +asking for a pack, even if it has already sent it with an earlier +command request, like `ls-refs` or `bundle-uri`. Note that when only +some object IDs are fetched, the client might not send any `ls-refs` +command request at all. + On the server side, the "promisor.advertise" and "promisor.sendFields" configuration options can be used to control what it advertises. On the client side, the "promisor.acceptFromServer" and -- 2.56.0