From: Jakub Kulik Date: Wed, 18 Nov 2026 16:01:47 GMT Subject: [PATCH] version: accept positive uname(2) return values Message-ID: <20261118160146.60429-2-jakub.kulik@oracle.com> In-Reply-To: POSIX specifies that uname(2) can return any non-negative value on success. Update the get_uname_info() check to follow this. Signed-off-by: Jakub Kulik --- Thank you. Hope this is how it should look. version.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/version.c b/version.c index 21ec7c0fbe..ca3be6d610 100644 --- a/version.c +++ b/version.c @@ -83,7 +83,7 @@ int get_uname_info(struct strbuf *buf, unsigned int full) { struct utsname uname_info; - if (uname(&uname_info)) { + if (uname(&uname_info) < 0) { strbuf_addf(buf, _("uname() failed with error '%s' (%d)\n"), strerror(errno), errno); -- 2.50.1