From: Cynthia Uche Date: Thu, 05 Nov 2026 12:25:31 GMT Subject: Re: [PATCH] api-parse-options: add missing flags and macros Message-ID: <20261105122532.391-1-herroyalpriestess@gmail.com> In-Reply-To: <20261105-kn-parse-options-doc-v1-1-403edda5947a@gmail.com> Hi Karthik, On Thu, Nov 5, 2026 at 11:37 AM Karthik Nayak wrote: > Also add the follow missing macros: nit: s/follow/following/. > - OPT_NO_WITH The message lists OPT_NO_WITH, but parse-options.h defines OPT_WITHOUT, which is what the diff documents. The diff also adds OPT_BITOP, OPT_STRVEC, OPT_UYN, OPT_NOOP_ARG and OPT_COLUMN, which the message doesn't list. I applied this on its base (8d1b215c01), built the docs with no warnings, and compared the descriptions with the code on master (0ffa3e35c7). OPT__VERBOSITY, OPT_UYN, OPT_BITOP, OPT_COLUMN, OPT_CONTAINS, OPT_NOOP_ARG and the two new flags match parse-options.c and parse-options-cb.c, and the git-add[1] references resolve via diff-context-options.adoc. OPT_ALIAS and OPT_ALIAS_F are still undocumented tho. I wonder if that is on purpose. -- Cynthia