From: Jeff King <peff@peff.net>
Date: Fri, 30 Oct 2026 18:22:11 GMT
Subject: Re: [PATCH 1/4] ident: remove unused author_ident_sufficiently_given()
Message-ID: <20261030182211.GC7582@coredump.intra.peff.net>
In-Reply-To: <20261030173956.585250-2-gitster@pobox.com>

On Fri, Oct 30, 2026 at 10:39:53AM -0700, Junio C Hamano wrote:

> A pair of functions {author,committer}_ident_sufficiently_given()
> were created to replace user_ident_explicitly_given() in d6991ceedc
> (ident: keep separate "explicit" flags for author and committer,
> 2012-11-14).
> 
> But author_ident_sufficiently_given() is never used in our history.
> We only check if committer ident is sufficiently given and use it to
> nudge the user to set user.{name,email} configuration variables.
> 
> Remove the unused author_ident_sufficiently_given() function.

Makes sense. I think I must have just added it for symmetry with the
committer one, but I agree it was never used. It almost looks like we
could drop author_ident_explicitly_given, too, which appears to be
write-only after this patch. But it is somewhat subtly used via
set_env_if() and prepare_fallback_ident(). So this seems like an obvious
cleanup and a good stopping point.

-Peff