From: Patrick Steinhardt Date: Wed, 28 Oct 2026 11:57:53 GMT Subject: [PATCH 1/7] builtin/commit-graph: rename subcommand functions Message-ID: <20261028-pks-commit-graph-cleanups-v1-1-c549344c363f@pks.im> In-Reply-To: <20261028-pks-commit-graph-cleanups-v1-0-c549344c363f@pks.im> Subcommands that we wire up via `OPT_SUBCOMMAND()` are typically called `cmd__()`, but we don't follow that pattern in "builtin/commit-graph.c". Rename the functions. Signed-off-by: Patrick Steinhardt --- builtin/commit-graph.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c index ff244c866fe..415eb6afee9 100644 --- a/builtin/commit-graph.c +++ b/builtin/commit-graph.c @@ -65,8 +65,10 @@ static struct option *add_common_options(struct option *to) return parse_options_concat(common_opts, to); } -static int graph_verify(int argc, const char **argv, const char *prefix, - struct repository *repo UNUSED) +static int cmd_commit_graph_verify(int argc, + const char **argv, + const char *prefix, + struct repository *repo UNUSED) { struct commit_graph *graph = NULL; struct odb_files_dir *dir = NULL; @@ -224,8 +226,10 @@ static int git_commit_graph_write_config(const char *var, const char *value, return 0; } -static int graph_write(int argc, const char **argv, const char *prefix, - struct repository *repo UNUSED) +static int cmd_commit_graph_write(int argc, + const char **argv, + const char *prefix, + struct repository *repo UNUSED) { struct string_list pack_indexes = STRING_LIST_INIT_DUP; struct strbuf buf = STRBUF_INIT; @@ -362,8 +366,8 @@ int cmd_commit_graph(int argc, { parse_opt_subcommand_fn *fn = NULL; struct option builtin_commit_graph_options[] = { - OPT_SUBCOMMAND("verify", &fn, graph_verify), - OPT_SUBCOMMAND("write", &fn, graph_write), + OPT_SUBCOMMAND("verify", &fn, cmd_commit_graph_verify), + OPT_SUBCOMMAND("write", &fn, cmd_commit_graph_write), OPT_END(), }; struct option *options = parse_options_concat(builtin_commit_graph_options, common_opts); -- 2.56.0.341.g393f52fd96.dirty