From: Jeff King Date: Wed, 14 Oct 2026 09:21:37 GMT Subject: Re: [PATCH v3 8/8] ci: improve reftable test coverage Message-ID: <20261014092137.GF1341124@coredump.intra.peff.net> In-Reply-To: <20261014-pks-ci-housekeeping-v3-8-04c24e1f480d@pks.im> On Wed, Oct 14, 2026 at 10:30:34AM +0200, Patrick Steinhardt wrote: > The "linux-reftable" job exercises Git with reftables as its default > backend. But this job is arguably redundant because we already have the > "linux-reftable-leaks" job that exercises reftables with the leak > sanitizer enabled, and it is unlikely that we will catch any extra bugs > with the leak sanitizer disabled. > > One may thus be triggered to just drop the "linux-reftable" job in favor > of the leak-checking variant. But the latter disables a couple of other > tests that exercise git-p4, git-svn and other tools. Those tools may not > be an essential part of Git nowadays, but I don't quite feel comfortable > with reducing test coverage. > > Instead, adapt the job to run reftables together with SHA256. which is > an area that we don't have test coverage for. Hmm. Aren't both sha256 and reftables by default part of the breaking changes flag? So I think we probably are already getting coverage there. -Peff