From: Jeff King Date: Wed, 14 Oct 2026 09:10:37 GMT Subject: Re: [PATCH v3 2/8] ci: fix "fedora-breaking-changes-meson" job Message-ID: <20261014091037.GB1341124@coredump.intra.peff.net> In-Reply-To: <20261014-pks-ci-housekeeping-v3-2-04c24e1f480d@pks.im> On Wed, Oct 14, 2026 at 10:30:28AM +0200, Patrick Steinhardt wrote: > The "fedora-breaking-changes-meson" job exercises Git with breaking > changes enabled on Fedora with Meson. There's a typo in our CI scripts > though, which has the effect that the build does not enable breaking > changes by accident. > > [...] > > case "$jobname" in > -fedora-breaking-changes-musl|linux-breaking-changes) > +fedora-breaking-changes-meson|linux-breaking-changes) > export WITH_BREAKING_CHANGES=YesPlease > MESONFLAGS="$MESONFLAGS -Dbreaking_changes=true" > ;; Seems obviously correct, but I wonder if just: *breaking-changes*) would fix this and prevent any issues for possible future jobs. The downside of a loose pattern is false matches, but it seems like a small risk given our universe of jobs. -Peff