From: Patrick Steinhardt Date: Fri, 09 Oct 2026 11:32:05 GMT Subject: [PATCH v2 8/8] ci: improve reftable test coverage Message-ID: <20261009-pks-ci-housekeeping-v2-8-6863d58ef691@pks.im> In-Reply-To: <20261009-pks-ci-housekeeping-v2-0-6863d58ef691@pks.im> The "linux-reftable" job exercises Git with reftables as its default backend. But this job is arguably redundant because we already have the "linux-reftable-leaks" job that exercises reftables with the leak sanitizer enabled, and it is unlikely that we will catch any extra bugs with the leak sanitizer disabled. One may thus be triggered to just drop the "linux-reftable" job in favor of the leak-checking variant. But the latter disables a couple of other tests that exercise git-p4, git-svn and other tools. Those tools may not be an essential part of Git nowadays, but I don't quite feel comfortable with reducing test coverage. Instead, adapt the job to run reftables together with SHA256. which is an area that we don't have test coverage for. Signed-off-by: Patrick Steinhardt --- .github/workflows/main.yml | 2 +- .gitlab-ci.yml | 2 +- ci/run-build-and-tests.sh | 6 +++++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 5b772dab55..0939833e57 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -405,7 +405,7 @@ jobs: - jobname: linux-sha256 image: ubuntu:rolling cc: clang - - jobname: linux-reftable + - jobname: linux-reftable-sha256 image: ubuntu:rolling cc: clang - jobname: linux-exotic diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index de40434ae3..b814963ff7 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -39,7 +39,7 @@ test:linux: - jobname: linux-sha256 image: ubuntu:rolling CC: clang - - jobname: linux-reftable + - jobname: linux-reftable-sha256 image: ubuntu:rolling CC: clang - jobname: linux-exotic diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh index 9381ff8893..c6e61d5794 100755 --- a/ci/run-build-and-tests.sh +++ b/ci/run-build-and-tests.sh @@ -40,7 +40,11 @@ linux-exotic) linux-sha256) export GIT_TEST_DEFAULT_HASH=sha256 ;; -linux-reftable|linux-reftable-leaks|osx-reftable) +linux-reftable-sha256) + export GIT_TEST_DEFAULT_HASH=sha256 + export GIT_TEST_DEFAULT_REF_STORAGE_FORMAT=reftable + ;; +linux-reftable-leaks|osx-reftable) export GIT_TEST_DEFAULT_REF_STORAGE_FORMAT=reftable ;; -- 2.56.0.170.g584c36229d.dirty