From: Andrew Pleeter <andrewpleeter@gmail.com>
Date: Fri, 02 Oct 2026 17:41:38 GMT
Subject: Re: [PATCH v9 0/4] var: -z output, multiple variables, and broken-out idents
Message-ID: <20261002174138.39096-1-andrewpleeter@gmail.com>
In-Reply-To: <33f24834-8e73-4230-bf0a-6809a85d9a86@gmail.com>

Hi Phillip,

Thanks for the review, and for the test_env pointer. Both nits are fair,
and both of those tests are newer than the rest of the series:

  - 3/4: "GIT_CONFIG_GLOBAL= git var ..." and "env GIT_CONFIG_GLOBAL=
    test_expect_code 1 git var ..." are clearly better than dragging a
    subshell in. I will use that style from here on.

  - 4/4: the per-component tests collapse into "get several identity
    components at once", which already covers the same ground.

I will fold both in if anything else prompts a v10. If the series goes in
as it stands, I can send them afterwards as a cleanup instead, whichever
Junio prefers.

Thanks also for the GIT_SIGNING_KEY questions. Dropping it was the right
call, and I would not have got there if you had not asked three times.

Thanks,
Andrew