From: Vsevolod Myalitsin <ub4nal@mail.ru>
Date: Thu, 10 Sep 2026 17:54:15 GMT
Subject: Re: [PATCH v4 2/3] advice: introduce advice scoping mechanism
Message-ID: <20260910175416.115280-1-ub4nal@mail.ru>
In-Reply-To: <20260910155247.GA251185@coredump.intra.peff.net>

Hi, Jeff!

> I'm really not sure why anybody would use those other flags, though (or
> even --system, for that matter). After reading the thread again, I get
> why we want "--global" for advice that only affects new repository
> creation (like defaultBranchName), since otherwise it could never have
> any effect. But why would you ever want --system?

I initially looked at Junio's suggestion and, based on his experience, didn't argue with it, and then I didn't come back to that message. I think the patch should contain not + enum config_scope scope_hint; but + bool is_global_hint;, since I myself can't find any scenarios where advice should be disabled at the system level.