From: Jeff King <peff@peff.net>
Date: Thu, 10 Sep 2026 16:31:20 GMT
Subject: Re: [PATCH] advice: use global config for default branch name
Message-ID: <20260910163120.GD251185@coredump.intra.peff.net>
In-Reply-To: <xmqq1pb147w2.fsf@gitster.g>

On Thu, Sep 10, 2026 at 05:18:21AM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > But I think the bigger question remains: if we did this, would people
> > find the extra lines giving the turn-off instructions ugly/overwhelming?
> > I'm not sure.
> 
> Well, if they find them unnecessary then they would want to turn it
> off and the instruction is already there ;-)

Well, it would certainly increase my desire to turn each one off. ;) I
guess you can set it to "true" to suppress the turn-off instructions
(but keep the advice itself).

> More seriously, if an advice item is found as such, then the item
> either must (1) be beneficial enough to be always shown, or (2) be
> so rarely shown that the turn-off instruction is unneeded.  It would
> inherently be case-by-case basis but I do think we would converge
> between unconditional advise() calls or advise_if_enabled() calls.

Right, I was wondering specifically if there are items in (1), but you
said it much better than I did. I guess we wouldn't know until we try
it and see people's reactions, though.

-Peff