From: Vsevolod Myalitsin <ub4nal@mail.ru>
Date: Wed, 09 Sep 2026 21:30:34 GMT
Subject: Re: [PATCH v3] advice: use global config for default branch name
Message-ID: <20260909213034.94554-1-ub4nal@mail.ru>
In-Reply-To: <xmqqse3ip2s5.fsf@gitster.g>

Hi Junio,

Thanks for the review.

> """Use this new mechanism to suggest setting advice.defaultBranchName
> in per-user configuration, not in per-repository configuration, as
> it is way too late once a repository is initialized.""" or something
> along that line is missing here.

Agreed. I'll add this motivation to the commit message.

> The change to narrow the interface into vadvise() needs to be
> described in the proposed log message.

I'll describe this change in the appropriate commit message.

> Ideally, this would be a three-patch series. API change to
> vadvise() would come first, and then the introduction of advice
> scope mechanism, and finally making defaultBranchName a global
> scope variable.

Agreed. I'll split the changes into three patches in this order.

I have one question about how the series should be organized. Since the
three patches will have different purposes, should each patch have its
own subject and commit message describing the changes introduced by that
patch? Or should they share a common subject/theme, with the individual
changes described in the respective commit messages?

> Style. In our codebase, switch and case are indented to the same
tabstop.

I'll fix the indentation.

> Other than that, the end shape looks good to me.

Thanks!

Vsevolod