From: Jeff King <peff@peff.net>
Date: Sat, 29 Aug 2026 11:15:49 GMT
Subject: Re: [PATCH v2] die_for_incompatible_opts(): unbounded number of options
Message-ID: <20260829111549.GB40814@coredump.intra.peff.net>
In-Reply-To: <xmqqbjana2wv.fsf@gitster.g>

On Thu, Aug 27, 2026 at 10:28:32AM -0700, Junio C Hamano wrote:

> +void die_for_incompatible_opts(bool opt1, const char *opt1_name, ...)

I'm mildly negative on this, just because there's no compiler support
for making sure there is an EOF somewhere. Keeping patch 1 and using
LAST_ARG_MUST_BE_NULL would be preferable, IMHO.

-Peff