From: Jeff King Date: Thu, 06 Aug 2026 15:41:03 GMT Subject: Re: [PATCH v2 11/11] bisect: handle dup() failure when redirecting stdout Message-ID: <20260806154103.GA1625706@coredump.intra.peff.net> In-Reply-To: <829cd82177a8e72e450d42db2af3166123c5b7c6.1785954661.git.gitgitgadget@gmail.com> On Wed, Aug 05, 2026 at 06:31:00PM +0000, Johannes Schindelin via GitGitGadget wrote: > diff --git a/builtin/bisect.c b/builtin/bisect.c > index ceb60b0626..733d28d377 100644 > --- a/builtin/bisect.c > +++ b/builtin/bisect.c > @@ -1308,7 +1308,12 @@ static int bisect_run(struct bisect_terms *terms, int argc, const char **argv) > > fflush(stdout); > saved_stdout = dup(1); > - dup2(temporary_stdout_fd, 1); > + if (saved_stdout < 0 || > + dup2(temporary_stdout_fd, 1) < 0) { > + res = error_errno(_("could not duplicate stdout")); > + close(temporary_stdout_fd); > + break; > + } Ironically this produces a new Coverity complaint. ;) If dup2() fails, then we break out of the loop, leaking saved_stdout. -Peff